Skip to content

3.x: Add onDropped callback to throttleFirst operator #7481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Desislav-Petrov opened this issue Nov 4, 2022 · 1 comment
Closed

3.x: Add onDropped callback to throttleFirst operator #7481

Desislav-Petrov opened this issue Nov 4, 2022 · 1 comment

Comments

@Desislav-Petrov
Copy link
Contributor

This PR adds an overload to the throttleFirst operator which takes an onDropped consumer.

This consumer is called when we're still within the gated time window when any new item isn't passed to downstream.

If the onDropped crashes, the exception is either delivered to the downstream (if the sequence is still live at that point) or to the global error handler (sequence is stopped).
Desislav-Petrov added a commit to Desislav-Petrov/RxJava that referenced this issue Nov 4, 2022
@Desislav-Petrov
Add onDropped callback for throttleFirst - addresses ReactiveX#7481
4e79c22
@akarnokd
Copy link
Member

akarnokd commented Nov 4, 2022

Not sure why you opened this issue. Just link to #7458 in your PRs.

@akarnokd akarnokd closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akarnokd @Desislav-Petrov