Implemented Next Operation #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #2 SUCCESS |
| } | ||
|
|
||
| if (lastItem.isOnError()) { | ||
| throw Exceptions.propagate(lastItem.getException()); |
There was a problem hiding this comment.
Should iterator.hasNext() throw an exception or just when next() is called?
The Javadoc for hasNext suggests it will never throw an Exception so I think that we should only throw from Iterator.next().
|
@mairbek Take a look at the changes I made in #166 to make hasNext() not throw an exception (I also added another unit test while reviewing). If you're happy with the changes I made I will merge that request which adds on top of your commits. Or if you want to do things differently and update this pull request that works as well (though please copy/paste in my new unit test). |
|
yeah, I'll close this one. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New implementation of #66.