Count, Sum, Average implementations #354
Merged
+491
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #245 SUCCESS |
|
Looks good to me. |
benjchristensen
added a commit
that referenced
this pull request
Sep 9, 2013
Count, Sum, Average implementations
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Count, Sum, Average implementations
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
* Add micrometer circuit breaker metrics binder based on tags * Add micrometer bulkhead metrics binder based on tags * Add micrometer rate limiter metrics binder based on tags * Add micrometer retry metrics binder based on tags * Add micrometer async retry metrics binder based on tags * Add documentation for tag based metrics
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…tiveX#375) * Introduce new prometheus metrics collector for bulkheads * Introduce new prometheus metrics collector for circuit breakers * Introduce new prometheus metrics collector for rate limiters * Avoid label list creation on every collect * Adapt/extend prometheus documentation * Improve metrics descriptions
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…cuit breaker state (ReactiveX#416)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented three easy operations here simply using
reduce.Two things were tricky however:
sum,sumLongs,sumFloats,sumDoubleshere (and the same for the averages).ArithmeticExceptionhere.Any other opinions?