Adding utility functions for observables of strings useful for processing non blocking IO. #457
Conversation
…sing non blocking IO.
|
RxJava-pull-requests #376 FAILURE |
|
Open question ... should static utility classes like this be kept in core or kept external in contrib-modules? These seems generic enough on Java primitives to be in core as opposed to Swing/Android which are kept in contrib modules. I'd like other feedback before making a decision. |
|
hello everyone, |
|
@karansinghkjs346 you should ask such question in http://groups.google.com/d/forum/rxjava. Your question is irrelevant to this PR. However, wiki is very helpful for you. https://github.com/Netflix/RxJava/wiki/How-to-Contribute and https://github.com/Netflix/RxJava/wiki |
Conflicts: rxjava-core/src/main/java/rx/observables/BlockingObservable.java
|
RxJava-pull-requests #390 FAILURE |
|
RxJava-pull-requests #391 FAILURE |
|
I have merged your second commit to PR #461. Thanks. |
Implement the scheduler overloads for Range, From, StartWith
from(scheduler) -> add diagram, standardize javadoc comments range(scheduler) -> add diagram, standardize javadoc comments startWith(scheduler) -> add diagram, standardize javadoc comments
ObserveOn Refactor
ParallelMerge Operator
- ObserveOn was not correctly recursing when the source was async. It would create a new scheduler (i.e. a new thread) each time. - Also added unit tests to ParallelMerge
…lelMerge Fix ObserveOn and add ParallelMerge Scheduler overload
- make Eclipse and Java/Scala interop happy
New Scala Bindings
Javadoc changes: * add links to RxJava wiki * correct obsolete <img> urls * remove unneeded version string from Linq URLs * standardize javadoc formatting * a few other minor javadoc corrections
Issue ReactiveX#23, Issue ReactiveX#88, Issue ReactiveX#100
Correcting for overzealous search-and-replace in javadoc comments
Empty subscribe
| * @param expected | ||
| * @param actual | ||
| */ | ||
| public static <T> void assertObservableEquals(Observable<T> expected, Observable<T> actual) { |
There was a problem hiding this comment.
Do these perhaps belong in a TestObservable class rather than BlockingObservable?
|
This looks like useful stuff ... can you rebase since it can no longer merge cleanly? Also I wonder if the |
Operators: And, Then, When
…sing non blocking IO.
…string-observable
|
RxJava-pull-requests #436 SUCCESS |
|
That merge picked up a huge number of changes (66 files), can you please close this and rebase your changes onto a clean branch? |
…aram plus some code refactoring (ReactiveX#457) * change fallback package * Review comments * Review comments
I started developing this for use with the rxjava-apache-http contrib module to safely and scalable decode infinite observables of byte arrays into strings but thought it should live in core because it could be useful for non blocking disk IO.
I did not make this part of rx.Observable because these operators only work on observables of string. The drawback is that discoverability will be harder.