2.x: Add Observable.rangeLong & Flowable.rangeLong #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
requested changes
Oct 11, 2016
| return just(start); | ||
| } | ||
|
|
||
| if (start + (count - 1) > Long.MAX_VALUE) { |
There was a problem hiding this comment.
That is always false. You should check if start + count - 1 flips to negative.
There was a problem hiding this comment.
I know that's why I wrote What should we do about the range overflow check? We could use BigDecimal to check that.
There was a problem hiding this comment.
You can do Long.MAX_VALUE - count > start or check just if it overflows negative like @akarnokd said.
There was a problem hiding this comment.
See intervalRange:
long end = start + (count - 1);
if (start > 0 && end < 0) {
throw new IllegalArgumentException("Overflow! start + count is bigger than Long.MAX_VALUE");
}There was a problem hiding this comment.
Oh cool didn't know that. Will change it thanks.
| Observer<? super Long> actual = this.actual; | ||
| long e = end; | ||
| for (long i = index; i != e && get() == 0; i++) { | ||
| actual.onNext((long)i); |
| return just(start); | ||
| } | ||
|
|
||
| if (start + (count - 1) > Long.MAX_VALUE) { |
There was a problem hiding this comment.
Same overflow check here as in Flowable.
Current coverage is 81.89% (diff: 54.08%)@@ 2.x #4687 diff @@
==========================================
Files 565 567 +2
Lines 37440 37599 +159
Methods 0 0
Messages 0 0
Branches 5746 5786 +40
==========================================
+ Hits 30753 30791 +38
- Misses 4612 4715 +103
- Partials 2075 2093 +18
|
akarnokd
approved these changes
Oct 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #4683
both implementations are copied same for the unit tests.
What should we do about the range overflow check? We could use BigDecimal to check that.