Skip to content

Conversation

@JakeWharton
Copy link
Contributor

Refs #5044.

@JakeWharton
Copy link
Contributor Author

Once wording and tests are approved I'll port to 1.x as well.

Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

(Forgot about testing all signal types as well, so 5 x 3 x 3, but I don't require it.)

@akarnokd akarnokd added this to the 2.0 backlog milestone Feb 2, 2017
@JakeWharton
Copy link
Contributor Author

Hmm I seem to be fighting the cool documentation checker which is being a bit too clever in this instance. I'm using the word "Subscription" at the beginning of a sentence which it thinks means Subscription the type. I'll figure out a wording tweak to make it end up as a lowercase "subscription".

@JakeWharton
Copy link
Contributor Author

Also with regard to signal types, I figure the other tests cover those already so in these cases we're just guarding against ordering changes.

@akarnokd
Copy link
Member

akarnokd commented Feb 2, 2017

Yes, lowercase it as Subscription is interpreted as the reference to the type.

@codecov
Copy link

codecov bot commented Feb 2, 2017

Codecov Report

Merging #5047 into 2.x will increase coverage by 0.08%.

@@             Coverage Diff             @@
##                2.x   #5047      +/-   ##
===========================================
+ Coverage     95.52%   95.6%   +0.08%     
- Complexity     5539    5541       +2     
===========================================
  Files           612     612              
  Lines         39576   39576              
  Branches       5553    5553              
===========================================
+ Hits          37804   37838      +34     
+ Misses          773     758      -15     
+ Partials        999     980      -19
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 112 <ø> (ø)
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 167 <ø> (ø)
src/main/java/io/reactivex/Single.java 99.29% <ø> (ø) 130 <ø> (ø)
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 504 <ø> (ø)
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 520 <ø> (ø)
...ternal/operators/flowable/FlowableSubscribeOn.java 90.9% <ø> (-7.28%) 2% <ø> (ø)
...nternal/operators/observable/ObservableCreate.java 92.85% <ø> (-5.36%) 2% <ø> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 93.87% <ø> (-4.09%) 2% <ø> (ø)
...ternal/operators/observable/ObservablePublish.java 91.89% <ø> (-3.61%) 10% <ø> (ø)
.../operators/observable/ObservableFlatMapSingle.java 92.53% <ø> (-2.99%) 2% <ø> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ccc453...665d59b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants