-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct java doc for refCount() return type. v2.0.7 #5191
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5191 +/- ##
============================================
+ Coverage 95.93% 95.96% +0.02%
- Complexity 5667 5679 +12
============================================
Files 621 621
Lines 40611 40611
Branches 5632 5632
============================================
+ Hits 38960 38971 +11
+ Misses 663 658 -5
+ Partials 988 982 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change it to an {@link Observable}
?
@@ -68,7 +68,7 @@ public final Disposable connect() { | |||
* Returns an {@code Observable} that stays connected to this {@code ConnectableObservable} as long as there | |||
* is at least one subscription to this {@code ConnectableObservable}. | |||
* | |||
* @return a {@link Flowable} | |||
* @return a {@link Observable} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an
fixed! |
Thanks! |
Java doc for
ConnectableObservable.refCount()
says it returns aFlowable
, but it should beObservable