Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] UnicastSubject fail fast support #5217

Merged
merged 4 commits into from
Mar 23, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions src/main/java/io/reactivex/subjects/UnicastSubject.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

package io.reactivex.subjects;

import io.reactivex.annotations.Experimental;
import io.reactivex.annotations.Nullable;
import io.reactivex.plugins.RxJavaPlugins;
import java.util.concurrent.atomic.*;
Expand Down Expand Up @@ -82,7 +83,7 @@ public final class UnicastSubject<T> extends Subject<T> {
*/
@CheckReturnValue
public static <T> UnicastSubject<T> create() {
return new UnicastSubject<T>(bufferSize());
return new UnicastSubject<T>(bufferSize(), true);
}

/**
Expand All @@ -93,7 +94,7 @@ public static <T> UnicastSubject<T> create() {
*/
@CheckReturnValue
public static <T> UnicastSubject<T> create(int capacityHint) {
return new UnicastSubject<T>(capacityHint);
return new UnicastSubject<T>(capacityHint, true);
}

/**
Expand Down Expand Up @@ -127,12 +128,13 @@ public static <T> UnicastSubject<T> create(int capacityHint, Runnable onTerminat
* @return an UnicastSubject instance
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add @since 2.0.8 - experimental to all the new methods.

@CheckReturnValue
@Experimental
public static <T> UnicastSubject<T> create(int capacityHint, Runnable onTerminate, boolean delayError) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be marked Experimental?

return new UnicastSubject<T>(capacityHint, onTerminate, delayError);
}

/**
* Creates an UnicastSubject with an internal buffer capacity hint 16 and given delay error flag
* Creates an UnicastSubject with an internal buffer capacity hint 16 and given delay error flag.
*
* <p>The callback, if not null, is called exactly once and
* non-overlapped with any active replay.
Expand All @@ -142,6 +144,7 @@ public static <T> UnicastSubject<T> create(int capacityHint, Runnable onTerminat
* @return an UnicastSubject instance
*/
@CheckReturnValue
@Experimental
public static <T> UnicastSubject<T> create(boolean delayError) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be marked Experimental?

return new UnicastSubject<T>(bufferSize(), delayError);
}
Expand Down Expand Up @@ -174,15 +177,6 @@ public static <T> UnicastSubject<T> create(boolean delayError) {
this(capacityHint, onTerminate, true);
}

/**
* Creates an UnicastSubject with the given capacity hint.
* @param capacityHint the capacity hint for the internal, unbounded queue
* @since 2.0
*/
UnicastSubject(int capacityHint) {
this(capacityHint, true);
}

/**
* Creates an UnicastSubject with the given capacity hint, delay error flag and callback
* for when the Subject is terminated normally or its single Subscriber cancels.
Expand Down