-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] UnicastSubject fail fast support #5217
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fb9d28c
[2.x] Unicast subject fail fast support
mostroverkhov ae5c8f6
follow up: mark new factory methods experimental, remove excessive co…
mostroverkhov 6c53e63
follow up: test coverage
mostroverkhov efcd9a9
follow up: add @since for new methods
mostroverkhov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ | |
|
||
package io.reactivex.subjects; | ||
|
||
import io.reactivex.annotations.Experimental; | ||
import io.reactivex.annotations.Nullable; | ||
import io.reactivex.plugins.RxJavaPlugins; | ||
import java.util.concurrent.atomic.*; | ||
|
@@ -82,7 +83,7 @@ public final class UnicastSubject<T> extends Subject<T> { | |
*/ | ||
@CheckReturnValue | ||
public static <T> UnicastSubject<T> create() { | ||
return new UnicastSubject<T>(bufferSize()); | ||
return new UnicastSubject<T>(bufferSize(), true); | ||
} | ||
|
||
/** | ||
|
@@ -93,7 +94,7 @@ public static <T> UnicastSubject<T> create() { | |
*/ | ||
@CheckReturnValue | ||
public static <T> UnicastSubject<T> create(int capacityHint) { | ||
return new UnicastSubject<T>(capacityHint); | ||
return new UnicastSubject<T>(capacityHint, true); | ||
} | ||
|
||
/** | ||
|
@@ -127,12 +128,13 @@ public static <T> UnicastSubject<T> create(int capacityHint, Runnable onTerminat | |
* @return an UnicastSubject instance | ||
*/ | ||
@CheckReturnValue | ||
@Experimental | ||
public static <T> UnicastSubject<T> create(int capacityHint, Runnable onTerminate, boolean delayError) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be marked Experimental? |
||
return new UnicastSubject<T>(capacityHint, onTerminate, delayError); | ||
} | ||
|
||
/** | ||
* Creates an UnicastSubject with an internal buffer capacity hint 16 and given delay error flag | ||
* Creates an UnicastSubject with an internal buffer capacity hint 16 and given delay error flag. | ||
* | ||
* <p>The callback, if not null, is called exactly once and | ||
* non-overlapped with any active replay. | ||
|
@@ -142,6 +144,7 @@ public static <T> UnicastSubject<T> create(int capacityHint, Runnable onTerminat | |
* @return an UnicastSubject instance | ||
*/ | ||
@CheckReturnValue | ||
@Experimental | ||
public static <T> UnicastSubject<T> create(boolean delayError) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be marked Experimental? |
||
return new UnicastSubject<T>(bufferSize(), delayError); | ||
} | ||
|
@@ -174,15 +177,6 @@ public static <T> UnicastSubject<T> create(boolean delayError) { | |
this(capacityHint, onTerminate, true); | ||
} | ||
|
||
/** | ||
* Creates an UnicastSubject with the given capacity hint. | ||
* @param capacityHint the capacity hint for the internal, unbounded queue | ||
* @since 2.0 | ||
*/ | ||
UnicastSubject(int capacityHint) { | ||
this(capacityHint, true); | ||
} | ||
|
||
/** | ||
* Creates an UnicastSubject with the given capacity hint, delay error flag and callback | ||
* for when the Subject is terminated normally or its single Subscriber cancels. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add
@since 2.0.8 - experimental
to all the new methods.