2.x: fix periodic scheduling with negative period causing IAE #5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
approved these changes
Jun 16, 2017
This was referenced Jun 19, 2017
This was referenced Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests to verify the
Scheduler.schedulePeriodicallyDirectandScheduler.Worker.schedulePeriodicallyworks with non-positive period as required by the Javadoc.The
computationandsingleschedulers were not working properly and the underlyingScheduledExecutorServicecrashed withIllegalArgumentExceptionthus these are now fixed with custom handler for theperiod <= 0Lcases.Related: #5416.