2.x: fix Completable.concat to use replace (don't dispose old) #5695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #5695 +/- ##
===========================================
+ Coverage 96.23% 96.3% +0.07%
Complexity 5818 5818
===========================================
Files 634 634
Lines 41604 41604
Branches 5761 5761
===========================================
+ Hits 40037 40067 +30
+ Misses 628 610 -18
+ Partials 939 927 -12
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Oct 31, 2017
artem-zinnatullin
approved these changes
Oct 31, 2017
| for (int i = 0; i < count; i++) { | ||
| Completable.complete() | ||
| .subscribeOn(Schedulers.io()) | ||
| .observeOn(Schedulers.io()) // The problem does not occur if you comment out this line |
There was a problem hiding this comment.
Can we delete these comments?
| try { | ||
| Thread.sleep(30); | ||
| } catch (InterruptedException e) { | ||
| System.out.println("Interrupted! " + Thread.currentThread()); // This is output periodically |
There was a problem hiding this comment.
I don't think we need it, or at least message should be changed to something like System.err.println("Interrupted, but was not expected to")
| for (int k = 0; k < 100; k++) { | ||
| final int count = 10; | ||
| final CountDownLatch latch = new CountDownLatch(count); | ||
| final boolean[] interrupted = { false }; |
There was a problem hiding this comment.
nit: AtomicBoolean would be a nicer replacement for mutable Boolean :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completable.andThen,concat(Iterable)andconcatArray()disposed the previousDisposablewhen receiving the newDisposablefrom the next source which could lead to interruption.concat(Publisher)already usesreplaceinstead ofupdate.There is a peculiar interplay between
subscribeOn,observeOnand the trampoline inconcatwhich can trigger such an interruption: the task of theobserveOnis cancelled withmayInterruptIfRunning == truebecause thedisposecall chain shuts down the worker of theobserveOnfrom thesubscribeOn's thread.Reported in #5694