-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Implement as() #5729
Merged
Merged
2.x: Implement as() #5729
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d7b5fc2
Implement Observable.as()
ZacSweers eb276a6
Implement Single.as()
ZacSweers a847033
Implement Maybe.as()
ZacSweers d82c4ee
Implement Flowable.as()
ZacSweers 9bebf29
Implement Completable.as()
ZacSweers 1aa5208
Add Experimental annotations
ZacSweers 68e2109
Add throws doc
ZacSweers 8b67bbf
Fix docs and validation errors
ZacSweers 1914776
Add @since 2.1.7 - experimental
ZacSweers 8adb583
ParallelFlowable.as()
ZacSweers c1f26ee
Start ConverterTest
ZacSweers e13a978
Fix tests and update validator
akarnokd 68a14b9
Merge pull request #2 from akarnokd/AsConverterFix
ZacSweers 5c0dec5
Remove exceptions from signatures
ZacSweers c4b0c26
Remove exception signature from implementations
ZacSweers 5c3bdf3
Assert the full execution of extend() tests
ZacSweers e0d793f
Use test() helpers
ZacSweers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/** | ||
* Copyright (c) 2016-present, RxJava Contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex; | ||
|
||
import io.reactivex.annotations.*; | ||
|
||
/** | ||
* Convenience interface and callback used by the {@link Completable#as} operator to turn a Completable into another | ||
* value fluently. | ||
* | ||
* @param <R> the output type | ||
* @since 2.1.7 - experimental | ||
*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add |
||
@Experimental | ||
public interface CompletableConverter<R> { | ||
/** | ||
* Applies a function to the upstream Completable and returns a converted value of type {@code R}. | ||
* | ||
* @param upstream the upstream Completable instance | ||
* @return the converted value | ||
*/ | ||
@NonNull | ||
R apply(@NonNull Completable upstream); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* Copyright (c) 2016-present, RxJava Contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex; | ||
|
||
import io.reactivex.annotations.*; | ||
|
||
/** | ||
* Convenience interface and callback used by the {@link Flowable#as} operator to turn a Flowable into another | ||
* value fluently. | ||
* | ||
* @param <T> the upstream type | ||
* @param <R> the output type | ||
* @since 2.1.7 - experimental | ||
*/ | ||
@Experimental | ||
public interface FlowableConverter<T, R> { | ||
/** | ||
* Applies a function to the upstream Flowable and returns a converted value of type {@code R}. | ||
* | ||
* @param upstream the upstream Flowable instance | ||
* @return the converted value | ||
*/ | ||
@NonNull | ||
R apply(@NonNull Flowable<T> upstream); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* Copyright (c) 2016-present, RxJava Contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex; | ||
|
||
import io.reactivex.annotations.*; | ||
|
||
/** | ||
* Convenience interface and callback used by the {@link Maybe#as} operator to turn a Maybe into another | ||
* value fluently. | ||
* | ||
* @param <T> the upstream type | ||
* @param <R> the output type | ||
* @since 2.1.7 - experimental | ||
*/ | ||
@Experimental | ||
public interface MaybeConverter<T, R> { | ||
/** | ||
* Applies a function to the upstream Maybe and returns a converted value of type {@code R}. | ||
* | ||
* @param upstream the upstream Maybe instance | ||
* @return the converted value | ||
*/ | ||
@NonNull | ||
R apply(@NonNull Maybe<T> upstream); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* Copyright (c) 2016-present, RxJava Contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex; | ||
|
||
import io.reactivex.annotations.*; | ||
|
||
/** | ||
* Convenience interface and callback used by the {@link Observable#as} operator to turn an Observable into another | ||
* value fluently. | ||
* | ||
* @param <T> the upstream type | ||
* @param <R> the output type | ||
* @since 2.1.7 - experimental | ||
*/ | ||
@Experimental | ||
public interface ObservableConverter<T, R> { | ||
/** | ||
* Applies a function to the upstream Observable and returns a converted value of type {@code R}. | ||
* | ||
* @param upstream the upstream Observable instance | ||
* @return the converted value | ||
*/ | ||
@NonNull | ||
R apply(@NonNull Observable<T> upstream); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* Copyright (c) 2016-present, RxJava Contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex; | ||
|
||
import io.reactivex.annotations.*; | ||
|
||
/** | ||
* Convenience interface and callback used by the {@link Single#as} operator to turn a Single into another | ||
* value fluently. | ||
* | ||
* @param <T> the upstream type | ||
* @param <R> the output type | ||
* @since 2.1.7 - experimental | ||
*/ | ||
@Experimental | ||
public interface SingleConverter<T, R> { | ||
/** | ||
* Applies a function to the upstream Single and returns a converted value of type {@code R}. | ||
* | ||
* @param upstream the upstream Single instance | ||
* @return the converted value | ||
*/ | ||
@NonNull | ||
R apply(@NonNull Single<T> upstream); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
src/main/java/io/reactivex/parallel/ParallelFlowableConverter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* Copyright (c) 2016-present, RxJava Contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex.parallel; | ||
|
||
import io.reactivex.annotations.*; | ||
|
||
/** | ||
* Convenience interface and callback used by the {@link ParallelFlowable#as} operator to turn a ParallelFlowable into | ||
* another value fluently. | ||
* | ||
* @param <T> the upstream type | ||
* @param <R> the output type | ||
* @since 2.1.7 - experimental | ||
*/ | ||
@Experimental | ||
public interface ParallelFlowableConverter<T, R> { | ||
/** | ||
* Applies a function to the upstream ParallelFlowable and returns a converted value of type {@code R}. | ||
* | ||
* @param upstream the upstream ParallelFlowable instance | ||
* @return the converted value | ||
*/ | ||
@NonNull | ||
R apply(@NonNull ParallelFlowable<T> upstream); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add
@Experimental
and@since 2.1.7 - experimental
to all of them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1914776