Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix O.blockingIterable(int) & add O.blockingLatest marbles #5826

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

akarnokd
Copy link
Member

This PR fixes the Observable.blockingIterable(int) marble by using the blockingIterable redone earlier.

In addition, the PR adds a marble diagram to Observable.blockingLatest:

blockingLatest

@akarnokd akarnokd added this to the 2.2 milestone Jan 30, 2018
@codecov
Copy link

codecov bot commented Jan 30, 2018

Codecov Report

Merging #5826 into 2.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5826      +/-   ##
============================================
+ Coverage     96.41%   96.43%   +0.01%     
- Complexity     5813     5816       +3     
============================================
  Files           634      634              
  Lines         41761    41761              
  Branches       5796     5796              
============================================
+ Hits          40265    40272       +7     
- Misses          570      574       +4     
+ Partials        926      915      -11
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 509 <0> (ø) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 91.89% <0%> (-5.41%) 9% <0%> (-1%)
...ava/io/reactivex/processors/BehaviorProcessor.java 91.03% <0%> (-4.04%) 60% <0%> (+1%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.3% <0%> (-2.9%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableTakeLastTimed.java 96.29% <0%> (-2.78%) 2% <0%> (ø)
...vex/internal/operators/single/SingleTakeUntil.java 93.44% <0%> (-1.64%) 2% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 60.41% <0%> (-1.39%) 34% <0%> (-1%)
...tors/observable/ObservableSequenceEqualSingle.java 98.29% <0%> (-0.86%) 3% <0%> (ø)
.../operators/observable/ObservableSequenceEqual.java 98.31% <0%> (-0.85%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableTimeoutTimed.java 98.37% <0%> (-0.82%) 3% <0%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6e595...8692041. Read the comment docs.

@akarnokd akarnokd merged commit b8380e2 into ReactiveX:2.x Jan 30, 2018
@akarnokd akarnokd deleted the ObservableMarbles0130a branch January 30, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants