Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: improve JavaDocs of the subscribeActual methods #5981

Merged
merged 1 commit into from
Apr 29, 2018

Conversation

akarnokd
Copy link
Member

The PR improves the wording of the abstract subscribeActual method across the base reactive types.

@akarnokd akarnokd added this to the 2.2 milestone Apr 29, 2018
@codecov
Copy link

codecov bot commented Apr 29, 2018

Codecov Report

Merging #5981 into 2.x will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5981      +/-   ##
============================================
+ Coverage     98.23%   98.29%   +0.05%     
+ Complexity     6053     6050       -3     
============================================
  Files           656      656              
  Lines         44078    44078              
  Branches       6118     6118              
============================================
+ Hits          43299    43325      +26     
+ Misses          236      224      -12     
+ Partials        543      529      -14
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 115 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 535 <0> (ø) ⬇️
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 171 <0> (ø) ⬇️
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 557 <0> (ø) ⬇️
src/main/java/io/reactivex/Single.java 100% <ø> (ø) 146 <0> (ø) ⬇️
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 96.46% <0%> (-3.54%) 11% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b9628...71f1ba0. Read the comment docs.

@akarnokd akarnokd merged commit d07dfa1 into ReactiveX:2.x Apr 29, 2018
@akarnokd akarnokd deleted the SubscribeActualJavaDoc branch April 29, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants