Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable's javadoc cleanup #5992

Merged
merged 1 commit into from
May 4, 2018
Merged

Observable's javadoc cleanup #5992

merged 1 commit into from
May 4, 2018

Conversation

anthonyms
Copy link
Contributor

The sample code in the Observable javadoc erroneously uses onNext(Integer t) for a DisposableObserver<String>

This has been corrected to be onNext(String t)

The sample code in the Observable javadoc erroneously uses onNext(Integer t) for a DisposableObserver<String>
This has been corrected to be onNext(String t)
@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #5992 into 2.x will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5992      +/-   ##
============================================
- Coverage     98.28%   98.22%   -0.06%     
+ Complexity     6054     6051       -3     
============================================
  Files           656      656              
  Lines         44078    44078              
  Branches       6118     6118              
============================================
- Hits          43321    43297      -24     
- Misses          229      234       +5     
- Partials        528      547      +19
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 535 <0> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-5.98%) 2% <0%> (ø)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 96.46% <0%> (-3.54%) 11% <0%> (ø)
...activex/internal/schedulers/ScheduledRunnable.java 98.07% <0%> (-1.93%) 29% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...x/internal/operators/flowable/FlowablePublish.java 97.02% <0%> (-1.71%) 11% <0%> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 98.46% <0%> (-1.54%) 28% <0%> (-1%)
...ex/internal/operators/flowable/FlowableCreate.java 96.42% <0%> (-1.3%) 6% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-1.07%) 5% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbba23e...5609282. Read the comment docs.

@akarnokd akarnokd merged commit 214181f into ReactiveX:2.x May 4, 2018
@anthonyms anthonyms deleted the JavadocCleanup branch May 4, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants