2.x: Dedicated {Single|Maybe}.flatMap{Publisher|Observable} & andThen(Observable|Publisher) implementations #6024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
approved these changes
May 27, 2018
|
|
||
| @Override | ||
| public void onComplete() { | ||
| ObservableSource<? extends R> p = other; |
|
|
||
| @Override | ||
| public void onSuccess(T t) { | ||
| ObservableSource<? extends R> p; |
|
|
||
| @Override | ||
| public void onSuccess(T t) { | ||
| ObservableSource<? extends R> p; |
|
Benchmark comparison with baseline: (i7 4770K, Windows 7 x64, Java 8u172, JMH 1.20):
Other that 3 cases with slightly degraded throughput (probably Windows related), these are nice improvements. Comparing
These should be practically the same. There is also a slight performance drop for |
vanniktech
approved these changes
May 27, 2018
Codecov Report
@@ Coverage Diff @@
## 2.x #6024 +/- ##
============================================
+ Coverage 98.27% 98.28% +<.01%
- Complexity 6161 6173 +12
============================================
Files 660 665 +5
Lines 44557 44717 +160
Branches 6201 6205 +4
============================================
+ Hits 43790 43948 +158
- Misses 228 233 +5
+ Partials 539 536 -3
Continue to review full report at Codecov.
|
|
/cc @davidmoten |
davidmoten
approved these changes
May 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following operators directly instead of conversions between base types:
Single.flatMapObservableMaybe.flatMapObservableMaybe.flatMapPublisherCompletable.andThen(Observable)Completable.andThen(Publisher)The
Single.flatMapPublisherwas reimplemented in #6021 already.