Add marble diagrams to the Single.delay method #6076

UMFsimke · 2018-07-08T21:08:15Z

Here are marbles for delay operator in #5788

Please let me know if I need to change anything on the diagram itself. If not, please send me URL when you upload image within the project so I can change URL for the marble in the PR.

akarnokd · 2018-07-08T21:20:19Z

src/main/java/io/reactivex/Single.java

@@ -1996,6 +1998,8 @@

    /**
     * Delays the emission of the success or error signal from the current Single by the specified amount.
+     * <p>
+     * <img width="640" height="457" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/Delay.png" alt="">


It would be great if you indicated the delayError: true case.

akarnokd · 2018-07-08T21:20:40Z

src/main/java/io/reactivex/Single.java

@@ -1978,6 +1978,8 @@
    /**
     * Delays the emission of the success signal from the current Single by the specified amount.
     * An error signal will not be delayed.
+     * <p>
+     * <img width="640" height="457" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/Delay.png" alt="">


It would be great if you indicated errors are not delayed with this overload.

akarnokd · 2018-07-08T21:21:13Z

src/main/java/io/reactivex/Single.java

@@ -2017,6 +2021,8 @@
    /**
     * Delays the emission of the success signal from the current Single by the specified amount.
     * An error signal will not be delayed.
+     * <p>
+     * <img width="640" height="457" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/DelayScheduler.png" alt="">


It would be great if you indicated errors are not delayed with this overload.

Please also color the bottom arrows as orange to indicate they get executed on the provided scheduler.

akarnokd · 2018-07-08T21:21:23Z

src/main/java/io/reactivex/Single.java

@@ -2039,6 +2045,8 @@

    /**
     * Delays the emission of the success or error signal from the current Single by the specified amount.
+     * <p>
+     * <img width="640" height="457" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/DelayScheduler.png" alt="">


It would be great if you indicated the delayError: true case.

codecov · 2018-07-08T21:24:03Z

Codecov Report

Merging #6076 into 2.x will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #6076      +/-   ##
============================================
+ Coverage     98.26%   98.27%   +<.01%     
- Complexity     6192     6193       +1     
============================================
  Files           666      666              
  Lines         44806    44806              
  Branches       6206     6206              
============================================
+ Hits          44028    44031       +3     
- Misses          236      237       +1     
+ Partials        542      538       -4

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/io/reactivex/Single.java	`100% <ø> (ø)`	`146 <0> (ø)`	⬇️
...l/operators/observable/ObservableFlatMapMaybe.java	`84.96% <0%> (-4.58%)`	`2% <0%> (ø)`
...ernal/operators/flowable/FlowableFlatMapMaybe.java	`91.3% <0%> (-4.35%)`	`2% <0%> (ø)`
...a/io/reactivex/internal/util/QueueDrainHelper.java	`97.22% <0%> (-2.78%)`	`56% <0%> (-2%)`
...rnal/operators/observable/ObservableSwitchMap.java	`94.68% <0%> (-1.6%)`	`3% <0%> (ø)`
...internal/operators/flowable/FlowableSwitchMap.java	`95.28% <0%> (-1.42%)`	`3% <0%> (ø)`
...ternal/operators/completable/CompletableMerge.java	`96.42% <0%> (-1.2%)`	`2% <0%> (ø)`
...java/io/reactivex/processors/UnicastProcessor.java	`98.8% <0%> (-1.2%)`	`67% <0%> (-1%)`
...perators/mixed/ObservableSwitchMapCompletable.java	`98.94% <0%> (-1.06%)`	`3% <0%> (ø)`
...nternal/operators/parallel/ParallelSortedJoin.java	`94.89% <0%> (-0.73%)`	`2% <0%> (ø)`
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8a9852...627af51. Read the comment docs.

UMFsimke · 2018-07-08T23:20:02Z

PR is updated with representation of error events.

akarnokd · 2018-07-09T07:29:39Z

src/main/java/io/reactivex/Single.java

@@ -2017,6 +2021,8 @@
    /**
     * Delays the emission of the success signal from the current Single by the specified amount.
     * An error signal will not be delayed.
+     * <p>
+     * <img width="640" height="457" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/DelayScheduler.png" alt="">


Please also color the bottom arrows as orange to indicate they get executed on the provided scheduler.

akarnokd · 2018-07-09T07:29:43Z

src/main/java/io/reactivex/Single.java

@@ -2039,6 +2045,8 @@

    /**
     * Delays the emission of the success or error signal from the current Single by the specified amount.
+     * <p>
+     * <img width="640" height="457" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/DelaySchedulerIncludingError.png" alt="">


Please also color the bottom arrows as orange to indicate they get executed on the provided scheduler.

UMFsimke · 2018-07-09T19:24:54Z

I've updated colors. Please take a look when you have time. Thanks!

akarnokd · 2018-07-09T19:30:59Z

https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.delay.png
https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.delay.e.png
https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.delay.s.png
https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.delay.se.png

UMFsimke · 2018-07-09T19:36:34Z

Thanks, updated

Add marble diagrams to the Single.delay method

ddff1c2

akarnokd reviewed Jul 8, 2018

View reviewed changes

akarnokd added Documentation 2.x labels Jul 8, 2018

akarnokd added this to the 2.2 milestone Jul 8, 2018

Update marbles for Single.delay with error events

f7eb104

akarnokd reviewed Jul 9, 2018

View reviewed changes

Use correct marble diagram URLs for Single.delay methods

627af51

akarnokd approved these changes Jul 9, 2018

View reviewed changes

vanniktech approved these changes Jul 10, 2018

View reviewed changes

akarnokd merged commit fd76594 into ReactiveX:2.x Jul 10, 2018

UMFsimke deleted the SingleDelayOperatorMarbles branch July 15, 2018 23:27

akarnokd mentioned this pull request Jul 18, 2018

2.1.17 release preparations #6089

Closed

jared-bot mentioned this pull request Jul 23, 2018

Dependency update: RxJava xmartlabs/bigbang-template#113

Closed

jared-bot mentioned this pull request Jul 31, 2018

Dependency update: RxJava xmartlabs/bigbang-template#117

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add marble diagrams to the Single.delay method #6076

Add marble diagrams to the Single.delay method #6076

UMFsimke commented Jul 8, 2018

akarnokd Jul 8, 2018

akarnokd Jul 8, 2018

akarnokd Jul 8, 2018

akarnokd Jul 9, 2018

akarnokd Jul 8, 2018

codecov bot commented Jul 8, 2018 •

edited

Loading

UMFsimke commented Jul 8, 2018

akarnokd Jul 9, 2018

akarnokd Jul 9, 2018

UMFsimke commented Jul 9, 2018

akarnokd commented Jul 9, 2018

UMFsimke commented Jul 9, 2018

Add marble diagrams to the Single.delay method #6076

Add marble diagrams to the Single.delay method #6076

Conversation

UMFsimke commented Jul 8, 2018

akarnokd Jul 8, 2018

Choose a reason for hiding this comment

akarnokd Jul 8, 2018

Choose a reason for hiding this comment

akarnokd Jul 8, 2018

Choose a reason for hiding this comment

akarnokd Jul 9, 2018

Choose a reason for hiding this comment

akarnokd Jul 8, 2018

Choose a reason for hiding this comment

codecov bot commented Jul 8, 2018 • edited Loading

Codecov Report

UMFsimke commented Jul 8, 2018

akarnokd Jul 9, 2018

Choose a reason for hiding this comment

akarnokd Jul 9, 2018

Choose a reason for hiding this comment

UMFsimke commented Jul 9, 2018

akarnokd commented Jul 9, 2018

UMFsimke commented Jul 9, 2018

codecov bot commented Jul 8, 2018 •

edited

Loading