Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Add Completable marble diagrams (07/17a) #6083

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jul 17, 2018

This PR adds the following marble diagrams to Completable operators (#5789):

amb, ambArray

image
image

complete

image

concatArray, concat

image
image
image
image

defer

image

error

image
image

@akarnokd akarnokd added this to the 2.2 milestone Jul 17, 2018
@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #6083 into 2.x will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6083      +/-   ##
============================================
+ Coverage     98.25%   98.31%   +0.05%     
+ Complexity     6195     6194       -1     
============================================
  Files           667      667              
  Lines         44856    44856              
  Branches       6211     6211              
============================================
+ Hits          44074    44098      +24     
+ Misses          237      228       -9     
+ Partials        545      530      -15
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 116 <0> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-6.72%) 2% <0%> (ø)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...rnal/operators/observable/ObservableSwitchMap.java 93.08% <0%> (-3.2%) 3% <0%> (ø)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...java/io/reactivex/processors/UnicastProcessor.java 98.8% <0%> (-1.2%) 67% <0%> (-1%)
.../operators/mixed/FlowableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 2% <0%> (ø)
...x/internal/operators/flowable/FlowableGroupBy.java 94.67% <0%> (-0.85%) 3% <0%> (ø)
...vex/internal/operators/parallel/ParallelRunOn.java 96.61% <0%> (-0.49%) 8% <0%> (ø)
...main/java/io/reactivex/subjects/ReplaySubject.java 97.69% <0%> (-0.42%) 50% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535ab35...ada7ad3. Read the comment docs.

@akarnokd akarnokd merged commit 53dd15f into ReactiveX:2.x Jul 17, 2018
@akarnokd akarnokd deleted the CompletableMarbles0717 branch July 17, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants