Refactored BoundedReplaySubject, concurrency enhancements. #649
+793
−644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #583 SUCCESS |
|
I found a concurrency bug in the read-write refactorings and PR #651 enhancements should appear in here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the formerly
rx.operators.OperationReplay.CustomReplaySubjectintorx.subjects.BoundedReplaySubjectwith all sorts ofcreatefactory methods.Also mentioned in the forum.
Changed to the concurrency logic:
The former
Lockis now split into aReadWriteLock. In write phase, the buffer is updated; in read phase, the observers are notified. New subscribers will enter the read phase so replaying can be run in-parallel with the already subscribed observers.However, the source side of the subject is still blocked while replaying. I can't imagine any non-convoluted way to make this less blocking or lock free.