2.x: Fix publish().refCount() hang due to race #6505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workaround implementation to the
publish()
implementationsObservablePublish
andFlowablePublish
so that when used withrefCount
, a connection-disconnection race won't leave consumers hanging in certain situations.This was necessary to avoid the behavior change with the classic implementations used without
refCount
. In the alternate implementation, when the connectable terminates, the terminal event is signaled to late consumers until the operator is reset via theResettableConnectable
.The
refCount
operator detects the classic implementations through theObservablePublishClassic
andFlowablePublishClassic
internal interfaces and replaces them via the new implementations. The introduction of these interfaces were necessary to support 3rd party hooks that would intercept the classic connectable implementations via an arbitrary class whichrefCount
wouldn't recognize or replace.Fixes #6501