Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Fix switchMap incorrect sync-fusion & error management #6618

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

akarnokd
Copy link
Member

This PR fixes the incorrect request call inside switchMap when working with sync-fused sources.

Fixes: #6615

Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Déjà vu

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #6618 into 2.x will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #6618      +/-   ##
===========================================
+ Coverage     98.2%   98.25%   +0.04%     
- Complexity    6331     6337       +6     
===========================================
  Files          677      677              
  Lines        45506    45511       +5     
  Branches      6325     6326       +1     
===========================================
+ Hits         44691    44715      +24     
+ Misses         257      254       -3     
+ Partials       558      542      -16
Impacted Files Coverage Δ Complexity Δ
...internal/operators/flowable/FlowableSwitchMap.java 95.37% <100%> (-1.33%) 3 <0> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 91.53% <100%> (-3.15%) 3 <0> (ø)
.../operators/observable/ObservableFlatMapSingle.java 92.53% <0%> (-2.99%) 2% <0%> (ø)
...tivex/internal/schedulers/TrampolineScheduler.java 96.1% <0%> (-2.6%) 6% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.78% <0%> (-2.42%) 2% <0%> (ø)
...operators/observable/ObservableMergeWithMaybe.java 99.1% <0%> (-0.9%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 96.66% <0%> (-0.84%) 2% <0%> (ø)
...vex/internal/operators/flowable/FlowableCache.java 97.72% <0%> (-0.76%) 37% <0%> (-1%)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a8eef...5282b41. Read the comment docs.

@akarnokd akarnokd merged commit 8db3569 into ReactiveX:2.x Aug 14, 2019
@akarnokd akarnokd deleted the SwitchMapFusionFix2x branch August 14, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants