3.x: Fix window(time) possible interrupts while terminating #6674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the case in
window(time)
variants where the timer thread is busy with window emission and the upstream terminates on some other thread, the window emission is interrupted.So instead of disposing the timer/worker right after the upstream termination, aDISPOSE
message is queued up. Thus any ongoing drain loop from the timer thread can cleanup gracefully.After some additional considerations, there is no need for
DISPOSE
. The drain loop will take care of disposing the timer and the main downstream can simply be terminated.The 2.x fix will be in a separate PR shortly.
Fixes #6672