Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Update javadoc for observeOn to mention its eagerness #6722

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

akarnokd
Copy link
Member

Backport of #6700

Update javadoc to reflect the eagerness property of observeOn in Flowable and Observable classes.

Related #6697

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #6722 into 2.x will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6722      +/-   ##
============================================
- Coverage     98.26%   98.21%   -0.05%     
- Complexity     6346     6349       +3     
============================================
  Files           677      677              
  Lines         45527    45527              
  Branches       6333     6333              
============================================
- Hits          44737    44715      -22     
- Misses          246      256      +10     
- Partials        544      556      +12
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 567 <0> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 542 <0> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-5.98%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-3.81%) 2% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
...ava/io/reactivex/processors/BehaviorProcessor.java 96.86% <0%> (-2.25%) 60% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...l/operators/observable/ObservableFlatMapMaybe.java 88.88% <0%> (-1.97%) 2% <0%> (ø)
...nal/operators/observable/ObservablePublishAlt.java 94.39% <0%> (-1.87%) 15% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 92.27% <0%> (-1.45%) 2% <0%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb5f2c...bda6287. Read the comment docs.

@akarnokd akarnokd merged commit 5e1bc17 into ReactiveX:2.x Nov 21, 2019
@akarnokd akarnokd deleted the ObserveOnDoc2x branch November 21, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants