Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix diamonds, spelling, unnecessary code #6804

Merged
merged 1 commit into from
Dec 27, 2019

Conversation

akarnokd
Copy link
Member

  • Use diamond where possible
  • Remove type arguments where they can be now inferred under Java 8
  • Fix spelling errors
  • Remove unnecessary throws declarations

@akarnokd akarnokd added Cleanup 3.x Java 8 Issues and PRs related to Java 8 support labels Dec 27, 2019
@akarnokd akarnokd added this to the 3.0 milestone Dec 27, 2019
@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #6804 into 3.x will increase coverage by 0.02%.
The diff coverage is 99.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6804      +/-   ##
============================================
+ Coverage     98.26%   98.28%   +0.02%     
+ Complexity     6378     6376       -2     
============================================
  Files           711      711              
  Lines         46247    46243       -4     
  Branches       6330     6329       -1     
============================================
+ Hits          45443    45449       +6     
+ Misses          287      286       -1     
+ Partials        517      508       -9
Impacted Files Coverage Δ Complexity Δ
...3/internal/observers/DeferredScalarDisposable.java 97.91% <ø> (ø) 20 <0> (ø) ⬇️
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 89.9% <ø> (-3.73%) 2 <0> (ø)
.../rxjava3/internal/disposables/EmptyDisposable.java 100% <ø> (ø) 17 <0> (ø) ⬇️
...operators/completable/CompletableToObservable.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...a3/internal/operators/maybe/MaybeFromRunnable.java 100% <ø> (ø) 6 <0> (ø) ⬇️
.../operators/mixed/CompletableAndThenObservable.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...al/operators/flowable/FlowableMapNotification.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...nternal/operators/maybe/MaybeTimeoutPublisher.java 98.55% <100%> (ø) 2 <1> (ø) ⬇️
...3/internal/operators/flowable/FlowableGroupBy.java 95.59% <100%> (ø) 3 <0> (ø) ⬇️
...va3/internal/operators/flowable/FlowableDelay.java 100% <100%> (ø) 3 <0> (ø) ⬇️
... and 264 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6eb21b...dd18f1f. Read the comment docs.

@akarnokd akarnokd merged commit 79f8e6d into ReactiveX:3.x Dec 27, 2019
@akarnokd akarnokd deleted the UseDiamond1227 branch December 27, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Cleanup Java 8 Issues and PRs related to Java 8 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants