Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted unnecessary NPE tests #6846

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Deleted unnecessary NPE tests #6846

merged 3 commits into from
Jan 14, 2020

Conversation

slisaasquatch
Copy link
Contributor

@slisaasquatch slisaasquatch commented Jan 14, 2020

Resolves #6830

I have kept tests that arbitrarily throw NPEs like this one, and tests with Iterables that return null Iterators like this one.

Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many null tests were deleted that should have been kept.

@akarnokd akarnokd merged commit 9fec1c7 into ReactiveX:3.x Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #6846 into 3.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6846      +/-   ##
============================================
- Coverage     98.22%   98.21%   -0.02%     
+ Complexity     6380     6379       -1     
============================================
  Files           715      715              
  Lines         46522    46522              
  Branches       6387     6387              
============================================
- Hits          45698    45692       -6     
+ Misses          306      299       -7     
- Partials        518      531      +13
Impacted Files Coverage Δ Complexity Δ
...java3/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
.../operators/observable/ObservableFlatMapSingle.java 88.88% <0%> (-3.18%) 2% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 86.61% <0%> (-2.82%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 91.66% <0%> (-2.09%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98.18% <0%> (-1.82%) 3% <0%> (ø)
...ctivex/rxjava3/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...rnal/operators/observable/ObservableObserveOn.java 98.69% <0%> (-1.31%) 3% <0%> (ø)
...ava3/internal/operators/parallel/ParallelJoin.java 92.04% <0%> (-1.14%) 3% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 96.25% <0%> (-1.07%) 5% <0%> (ø)
...java3/internal/operators/flowable/FlowableZip.java 97.39% <0%> (-1.05%) 6% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336ecb8...5642fe6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Remove duplicate unit tests that check null arguments on standard operators
2 participants