Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix method argument naming across types #6853

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

akarnokd
Copy link
Member

Make method argument naming consistent between the base reactive classes, adjust some of the naming for all.

In addition, the null-check was missing from blockingMostRecent.

Resolves #6832

The utility program has to be run manually to list the inconsistencies. The remaining inconsistency is due to merge because its argument is sources for Flowable/Observable but source for Single/Maybe nested.

@akarnokd akarnokd added this to the 3.0 milestone Jan 21, 2020
@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #6853 into 3.x will decrease coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6853      +/-   ##
============================================
- Coverage     98.35%   98.22%   -0.14%     
+ Complexity     6379     6378       -1     
============================================
  Files           715      715              
  Lines         46522    46524       +2     
  Branches       6387     6387              
============================================
- Hits          45758    45697      -61     
- Misses          268      298      +30     
- Partials        496      529      +33
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <100%> (ø) 576 <15> (ø) ⬇️
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <100%> (ø) 178 <10> (ø) ⬇️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <100%> (ø) 120 <14> (ø) ⬇️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <100%> (ø) 151 <14> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <100%> (ø) 551 <26> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 87.32% <0%> (-9.16%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.09% <0%> (-8.74%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 91.45% <0%> (-7.7%) 2% <0%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 93.57% <0%> (-4.59%) 2% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021d07b...4ed4635. Read the comment docs.

@akarnokd akarnokd merged commit 0c84f40 into ReactiveX:3.x Jan 21, 2020
@akarnokd akarnokd deleted the ArgumentNamingConsistency branch January 21, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Validate argument naming consistency between base class methods
1 participant