Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add last missing throws tag to JavaDocs #6860

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

akarnokd
Copy link
Member

Added the last missing @throws tag to methods and one missing @NonNull annotation.

I included a small program that will list JavaDocs without @throws for future use.

Resolves #6829

@akarnokd akarnokd added this to the 3.0 milestone Jan 22, 2020
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #6860 into 3.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6860      +/-   ##
============================================
+ Coverage     98.24%   98.28%   +0.03%     
- Complexity     6379     6381       +2     
============================================
  Files           715      715              
  Lines         46524    46524              
  Branches       6387     6387              
============================================
+ Hits          45709    45727      +18     
+ Misses          294      286       -8     
+ Partials        521      511      -10
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <ø> (ø) 151 <0> (ø) ⬇️
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <ø> (ø) 576 <0> (ø) ⬇️
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 93.57% <0%> (-4.59%) 2% <0%> (ø)
...eactivex/rxjava3/processors/BehaviorProcessor.java 96.55% <0%> (-2.47%) 50% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 94.27% <0%> (-2.09%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.09% <0%> (-1.59%) 2% <0%> (ø)
...rxjava3/internal/schedulers/ExecutorScheduler.java 95.89% <0%> (-0.92%) 10% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-0.84%) 2% <0%> (ø)
.../operators/maybe/MaybeFlatMapIterableFlowable.java 95.9% <0%> (-0.82%) 2% <0%> (ø)
...3/internal/operators/flowable/FlowableGroupBy.java 96.22% <0%> (+0.31%) 3% <0%> (ø) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d59c5...9ae6e21. Read the comment docs.

@akarnokd akarnokd merged commit 5dbc2a8 into ReactiveX:3.x Jan 22, 2020
@akarnokd akarnokd deleted the ThrowsDocPresent branch January 22, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Ensure delegating operator overloads list all relevant @throws too in their Javadocs
2 participants