Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add remaining Maybe marbles (+50) #6897

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

akarnokd
Copy link
Member

Resolves #5806

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #6897 into 3.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6897      +/-   ##
============================================
+ Coverage     98.25%   98.25%   +<.01%     
- Complexity     6590     6598       +8     
============================================
  Files           740      742       +2     
  Lines         47293    47400     +107     
  Branches       6430     6443      +13     
============================================
+ Hits          46468    46574     +106     
- Misses          300      304       +4     
+ Partials        525      522       -3
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 208 <0> (ø) ⬇️
...a3/internal/operators/flowable/FlowableCreate.java 92.88% <0%> (-4.86%) 6% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 83.8% <0%> (-4.23%) 2% <0%> (ø)
...tivex/rxjava3/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...internal/operators/flowable/FlowableFromArray.java 96.61% <0%> (-1.7%) 3% <0%> (ø)
...ctivex/rxjava3/internal/util/QueueDrainHelper.java 98.61% <0%> (-1.39%) 57% <0%> (-1%)
...perators/observable/ObservableMergeWithSingle.java 99.05% <0%> (-0.95%) 2% <0%> (ø)
...al/operators/observable/ObservableWindowTimed.java 96.12% <0%> (-0.65%) 4% <0%> (ø)
...ternal/operators/flowable/FlowableWindowTimed.java 96.62% <0%> (-0.57%) 5% <0%> (ø)
...ternal/operators/observable/ObservableGroupBy.java 95.08% <0%> (-0.55%) 2% <0%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a795d...55a0867. Read the comment docs.

@akarnokd akarnokd merged commit 7e4bb8b into ReactiveX:3.x Jan 29, 2020
@akarnokd akarnokd deleted the MaybeMarbles_0129 branch January 29, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Maybe incorrect or missing marbles (tracking issue)
1 participant