Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix replay() not resetting when the connection is disposed #6921

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

akarnokd
Copy link
Member

Disposing a replay()-based connectable should reset the operator to its fresh state. This was supposed to happen but the relevant code changes were not enabled. The PR fixes this for both Flowable and Observable-based implementations.

The publish-based connectables work as intended.

Fixes #6920

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #6921 into 3.x will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6921      +/-   ##
============================================
- Coverage     99.65%   99.65%   -0.01%     
+ Complexity     6670     6669       -1     
============================================
  Files           742      742              
  Lines         47217    47220       +3     
  Branches       6367     6367              
============================================
  Hits          47055    47055              
- Misses           48       50       +2     
- Partials        114      115       +1     
Impacted Files Coverage Δ Complexity Δ
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 93.57% <0.00%> (-4.59%) 2.00% <0.00%> (ø%)
.../operators/observable/ObservableFlatMapSingle.java 94.44% <0.00%> (-2.39%) 2.00% <0.00%> (ø%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 95.34% <0.00%> (-2.33%) 2.00% <0.00%> (ø%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 95.85% <0.00%> (-2.08%) 2.00% <0.00%> (ø%)
...ternal/operators/completable/CompletableMerge.java 97.29% <0.00%> (-1.36%) 2.00% <0.00%> (ø%)
...a3/internal/operators/flowable/FlowableReplay.java 98.92% <0.00%> (-1.08%) 21.00% <0.00%> (-1.00%)
...perators/observable/ObservableMergeWithSingle.java 99.05% <0.00%> (-0.95%) 2.00% <0.00%> (ø%)
...ternal/operators/observable/ObservableFlatMap.java 98.17% <0.00%> (ø) 3.00% <0.00%> (ø%) ⬆️
...3/internal/operators/flowable/FlowableGroupBy.java 99.68% <0.00%> (+0.31%) 3.00% <0.00%> (ø%) ⬆️
...operators/flowable/FlowableConcatMapScheduler.java 99.60% <0.00%> (+0.39%) 4.00% <0.00%> (ø%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042dee3...32f5dbb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observable.replay - a bug or a feature?
2 participants