3.x: Patch out duplicate @NonNull annotation in generated javadocs #7073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a long-standing bug in either javac or javadocs that results in certain annotations to be put into the HTML twice:
https://bugs.openjdk.java.net/browse/JDK-8175533
Looks like it happens with certain
@Documented
annotations, but not others. The issue persists up to JDK 16 preview.This PR adds a workaround to the existing HTML patching gradle task which removes such duplicates:
Sidenote: yes, the method return also duplicates
@NonNull
, but that's across HTML elements and is much harder to fix.