Skip to content

3.x: Remove redundant addition of JMH to classpath #7257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benjamintboyle
Copy link
Contributor

Remove manual addition of JMH classpath in build file. Gradle adds classpath
for all sourceSets to Eclipse by default as fixed in Gradle 6.8 by PR
14534. The JMH sourceSet is added by the JMH Plugin.

Tested by running 'eclipse' task in Eclipse 2021-03 (4.19.0). Then refreshing,
and JMH still on classpath and viewable in Eclipse. Then removed project from
Eclipse, ran 'cleanEclipse', and re-imported project to Eclipse. All successful.

Remove manual addition of JMH classpath in build file. Gradle adds classpath
for all sourceSets to Eclipse by default as fixed in Gradle 6.8 by PR
14534. The JMH sourceSet is added by the JMH Plugin.

Tested by running 'eclipse' task in Eclipse 2021-03 (4.19.0). Then refreshing,
and JMH still on classpath and viewable in Eclipse. Then removed project from
Eclipse, ran 'cleanEclipse', and re-imported project to Eclipse. All successful.
@akarnokd akarnokd added this to the 3.1 milestone May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #7257 (d86131f) into 3.x (06294de) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7257      +/-   ##
============================================
- Coverage     99.57%   99.51%   -0.06%     
+ Complexity     6758     6756       -2     
============================================
  Files           747      747              
  Lines         47391    47391              
  Branches       6382     6382              
============================================
- Hits          47190    47163      -27     
- Misses           91       99       +8     
- Partials        110      129      +19     
Impacted Files Coverage Δ Complexity Δ
...l/operators/observable/ObservableFlatMapMaybe.java 89.43% <0.00%> (-7.75%) 2.00% <0.00%> (ø%)
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 93.57% <0.00%> (-4.59%) 2.00% <0.00%> (ø%)
...x/rxjava3/internal/operators/single/SingleAmb.java 96.61% <0.00%> (-3.39%) 9.00% <0.00%> (-1.00%)
...nternal/operators/observable/ObservableWindow.java 98.21% <0.00%> (-1.79%) 3.00% <0.00%> (ø%)
...ators/observable/ObservableFlatMapCompletable.java 98.52% <0.00%> (-1.48%) 2.00% <0.00%> (ø%)
...ternal/operators/completable/CompletableMerge.java 97.29% <0.00%> (-1.36%) 2.00% <0.00%> (ø%)
...operators/flowable/FlowableFlatMapCompletable.java 98.71% <0.00%> (-1.29%) 2.00% <0.00%> (ø%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 95.34% <0.00%> (-1.17%) 2.00% <0.00%> (ø%)
...ternal/operators/observable/ObservableGroupBy.java 98.90% <0.00%> (-1.10%) 2.00% <0.00%> (ø%)
...operators/observable/ObservableMergeWithMaybe.java 99.09% <0.00%> (-0.91%) 2.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06294de...d86131f. Read the comment docs.

@akarnokd akarnokd merged commit 8fb4640 into ReactiveX:3.x May 5, 2021
@benjamintboyle benjamintboyle deleted the remove-redundant-eclipse-classpath-jmh branch May 5, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants