-
Notifications
You must be signed in to change notification settings - Fork 7.6k
3.x: Move Gradle properties into gradle.properties file #7260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x: Move Gradle properties into gradle.properties file #7260
Conversation
Moved version, group, and description into gradle.properties file. Removed POM_ARTIFACT property as the 'name' property in the settings file is used when building the POM. Removed 'release.scope' property as it does not appear to be used. Removed VERSION_NAME property and references to it, in favor of 'version' property.
Also verified that the POM created does not change. Generated POM before changes and diff'd it with POM after changes. The POMs are identical. |
Codecov Report
@@ Coverage Diff @@
## 3.x #7260 +/- ##
============================================
- Coverage 99.56% 99.55% -0.02%
Complexity 6757 6757
============================================
Files 747 747
Lines 47391 47391
Branches 6382 6382
============================================
- Hits 47186 47180 -6
- Misses 93 97 +4
- Partials 112 114 +2 Continue to review full report at Codecov.
|
Removing some of the properties might break the release plugin: https://github.com/vanniktech/gradle-maven-publish-plugin#setting-properties |
Added POM_ARTIFACT_ID=rxjava in gradle.properties file
Replaced property for release plugin. |
VERSION_NAME and GROUP default to 'version' and 'group' as seen on Line 9 and 10 from Plugin source |
Moved version, group, and description into gradle.properties file.
Removed POM_ARTIFACT property as the 'name' property in the settings file
is used when building the POM. Removed 'release.scope' property as it
does not appear to be used. Removed VERSION_NAME property and references
to it, in favor of 'version' property.