make split methode workable with Pattern class #25
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,12 +1,12 @@ | |||
| /** | |||
| * Copyright 2014 Netflix, Inc. | |||
| * | |||
| * <p/> | |||
There was a problem hiding this comment.
Please don't change the license comment.
|
hope thats it... can you look on that? |
| @@ -355,24 +355,49 @@ public String call(Object obj) { | |||
| }); | |||
| } | |||
|
|
|||
| /** | |||
| /** | |||
There was a problem hiding this comment.
Indentation missing here. Could you also squash the commits into just a single one?
added 4 commits
July 29, 2015 15:37
|
Almost good. Could you squash the commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ...
this is a simple change to make split workable with precompiled 'Regex' Patterns.
Thanks,
Arek