Add backpressure support for StringObservable.from(InputStream) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| //check if we have finished | ||
| if (numRead == -1 && !subscriber.isUnsubscribed()) | ||
| subscriber.onCompleted(); |
There was a problem hiding this comment.
A return is missing here; without it, the while loop would spin until the downstream actually unsubscribes.
|
I'd like to hold on this PR until RxJava gets to 1.0.5. |
|
Thanks for feedback @akarnokd. The creation of this actually predates your |
|
PR for this ready to go. Just waiting on rxjava 1.0.9 release with |
|
superseded by #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backpressure support added for
StringObservable.from(InputStream)including a few unit tests.Once this PR makes it through can add a similar one for
StringObservable.from(Reader).