Add support template types #218
Conversation
WyriHaximus
force-pushed
the
template-types
branch
11 times, most recently
from
022ee96
to
006cb2a
Compare
Requires: ReactiveX/RxPHP#218
WyriHaximus
force-pushed
the
template-types
branch
3 times, most recently
from
9c0ae45
to
63ee9a6
Compare
| @@ -2,7 +2,8 @@ parameters: | |||
| level: max | |||
|
|
|||
| paths: | |||
| - src/ | |||
| - test/types/ | |||
There was a problem hiding this comment.
Didn't widen this to include the entire test directory because that would add 1752 errors to solve. This PR alone was already almost 1K.
WyriHaximus
force-pushed
the
template-types
branch
from
63ee9a6
to
973a382
Compare
| * @var Observable<T> $observable | ||
| */ | ||
| $observable = Observable::of($x, $this->scheduler); | ||
| $newDisp = $observable->delay($this->nextSend - $now, $this->scheduler) |
There was a problem hiding this comment.
This one is interesting, while this class accepts the SchedulerInterface which can also be the AsyncSchedulerInterface however. The delay method on an observable only accepts the AsyncSchedulerInterface. What to do here?
WyriHaximus
force-pushed
the
template-types
branch
from
973a382
to
e0d57b2
Compare
WyriHaximus
force-pushed
the
template-types
branch
from
e0d57b2
to
af34b8d
Compare
WyriHaximus
changed the title
|
@davidwdan && @mbonneau This covers the basics ( 😅 ) and is ready for review. Is there anything you want me to add in the |
Requires: ReactiveX/RxPHP#218
Requires: ReactiveX/RxPHP#218
|
The first package update was successful based on this branch: |
Requires: ReactiveX/RxPHP#218
Depends on #217