Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completeable is misspelled. #1134

Closed
1 task done
ZacSweers opened this issue Mar 13, 2017 · 6 comments
Closed
1 task done

Completeable is misspelled. #1134

ZacSweers opened this issue Mar 13, 2017 · 6 comments

Comments

@ZacSweers
Copy link

Short description of the issue:

The new Completeable class is misspelled. RxJava's is Completable.

Expected outcome:

It should be Completable if we want to match RxJava.

Level of RxSwift knowledge:
(this is so we can understand your level of knowledge
and formulate the response in an appropriate manner)

  • just starting, but an active contributor to RxJava
@kzaher
Copy link
Member

kzaher commented Mar 13, 2017

Hi @hzsweers ,

Thnx for reporting this. We've already been informed. I'll create a patch release tonight.

@ZacSweers
Copy link
Author

Thanks!

kzaher added a commit that referenced this issue Mar 13, 2017
@kzaher
Copy link
Member

kzaher commented Mar 13, 2017

Hi @hzsweers ,

I've pushed changes to develop branch.

Do you maybe see anywhere some other mistypes or anomalies before I start pre release tests?

@ZacSweers
Copy link
Author

Only other thing that comes to mind is that RxJava 2 follows the reactive streams nomenclature of saying onComplete rather than onCompleted. That's probably out of scope for this though since Observable uses it as well. Might be worth making new operators abide by it though?

@kzaher
Copy link
Member

kzaher commented Mar 13, 2017

Yeah, let's focus on the obvious for now :)

@ZacSweers
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants