Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

docs(operators): add documentation for windowWhen #291

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

docs(operators): add documentation for windowWhen #291

wants to merge 9 commits into from

Conversation

hardikpthv
Copy link
Contributor

Closes: #127

@codecov-io
Copy link

codecov-io commented Mar 1, 2018

Codecov Report

Merging #291 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         116      116           
  Lines         445      445           
  Branches        9        9           
=======================================
  Hits          404      404           
  Misses         40       40           
  Partials        1        1
Impacted Files Coverage Δ
src/operator-docs/transformation/windowWhen.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4097607...4bca2d1. Read the comment docs.

const clicks = Rx.Observable.fromEvent(document, 'click');
const result = clicks
.windowWhen(() => interval(1000 + Math.random() * 4000))
.map(win => win.take(2)) // each window has at most 2 emissions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use es6 imports and pipe operator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niklas-wortmann
Copy link
Member

@hardikpthv I think after the changes requested by ashwin, this pr can be merged. Do you need any help with this one?

@hardikpthv
Copy link
Contributor Author

Sorry, @jwo719 got busy these days, so couldn't make proposed changes. Let me check this one. I will let you know in case of help. :)

@hardikpthv
Copy link
Contributor Author

@jwo719, @ashwin-sureshkumar requested changes are made do let me know if anything else is required.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants