-
Notifications
You must be signed in to change notification settings - Fork 62
docs(operators): add documentation for windowWhen #291
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 116 116
Lines 445 445
Branches 9 9
=======================================
Hits 404 404
Misses 40 40
Partials 1 1
Continue to review full report at Codecov.
|
const clicks = Rx.Observable.fromEvent(document, 'click'); | ||
const result = clicks | ||
.windowWhen(() => interval(1000 + Math.random() * 4000)) | ||
.map(win => win.take(2)) // each window has at most 2 emissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use es6 imports and pipe operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay @ashwin-sureshkumar
@hardikpthv I think after the changes requested by ashwin, this pr can be merged. Do you need any help with this one? |
Sorry, @jwo719 got busy these days, so couldn't make proposed changes. Let me check this one. I will let you know in case of help. :) |
@jwo719, @ashwin-sureshkumar requested changes are made do let me know if anything else is required. |
Closes: #127