Skip to content

Commit

Permalink
Merge pull request #5743 from cartant/firehose-tests-fixed-by-smallify
Browse files Browse the repository at this point in the history
test: enable now-passing firehose tests
  • Loading branch information
benlesh authored Sep 23, 2020
2 parents 78effd9 + 525d130 commit 879703b
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 11 deletions.
1 change: 0 additions & 1 deletion spec/operators/catchError-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,6 @@ describe('catchError operator', () => {
);
});

// TODO: fix firehose unsubscription
it('should stop listening to a synchronous observable when unsubscribed', () => {
const sideEffects: number[] = [];
const synchronousObservable = new Observable(subscriber => {
Expand Down
3 changes: 1 addition & 2 deletions spec/operators/exhaust-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,7 @@ describe('exhaust operator', () => {
});
});

// TODO: fix firehose unsubscription
it.skip('should stop listening to a synchronous observable when unsubscribed', () => {
it('should stop listening to a synchronous observable when unsubscribed', () => {
const sideEffects: number[] = [];
const synchronousObservable = new Observable<number>(subscriber => {
// This will check to see if the subscriber was closed on each loop
Expand Down
3 changes: 1 addition & 2 deletions spec/operators/exhaustMap-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,7 @@ describe('exhaustMap', () => {
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

// TODO: fix firehose unsubscription
it.skip('should stop listening to a synchronous observable when unsubscribed', () => {
it('should stop listening to a synchronous observable when unsubscribed', () => {
const sideEffects: number[] = [];
const synchronousObservable = new Observable<number>(subscriber => {
// This will check to see if the subscriber was closed on each loop
Expand Down
3 changes: 1 addition & 2 deletions spec/operators/raceWith-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,7 @@ describe('raceWith operator', () => {
expect(onUnsubscribe.calledOnce).to.be.true;
});

// TODO: fix firehose unsubscription
it.skip('should stop listening to a synchronous observable when unsubscribed', () => {
it('should stop listening to a synchronous observable when unsubscribed', () => {
const sideEffects: number[] = [];
const synchronousObservable = new Observable<number>(subscriber => {
// This will check to see if the subscriber was closed on each loop
Expand Down
3 changes: 1 addition & 2 deletions spec/operators/retryWhen-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,7 @@ describe('retryWhen operator', () => {
expect(results).to.deep.equal([1, 2, 'teardown', 1, 2, 'teardown', 1, 2, 'teardown', 1, 2, 'bad', 'teardown'])
});

// TODO: fix firehose unsubscription
it.skip('should stop listening to a synchronous observable when unsubscribed', () => {
it('should stop listening to a synchronous observable when unsubscribed', () => {
const sideEffects: number[] = [];
const synchronousObservable = new Observable<number>(subscriber => {
// This will check to see if the subscriber was closed on each loop
Expand Down
3 changes: 1 addition & 2 deletions spec/operators/single-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,7 @@ describe('single operator', () => {
});
});

// TODO: fix firehose unsubscription
it.skip('should stop listening to a synchronous observable when unsubscribed', () => {
it('should stop listening to a synchronous observable when unsubscribed', () => {
const sideEffects: number[] = [];
const synchronousObservable = new Observable<number>(subscriber => {
// This will check to see if the subscriber was closed on each loop
Expand Down

0 comments on commit 879703b

Please sign in to comment.