fix(delay): fix memory leak

ReactiveX · May 3, 2018 · 8afb492 · 8afb492
1 parent 60e7521
commit 8afb492
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/spec/operators/delay-spec.ts b/spec/operators/delay-spec.ts
@@ -1,5 +1,5 @@
-import { Observable, timer } from 'rxjs';
-import { delay, repeatWhen, skip, take, tap, finalize } from 'rxjs/operators';
+import { Observable } from 'rxjs';
+import { delay, repeatWhen, skip, take, tap } from 'rxjs/operators';
 import { TestScheduler } from 'rxjs/testing';
 import * as sinon from 'sinon';
 import { expect } from 'chai';
@@ -147,12 +147,12 @@ describe('Observable.prototype.delay', () => {
  expectObservable(result).toBe(expected);
  });
 
- it('should unsubscribe scheduled action when result is unsubscribed explicitly', () => {
+ it('should unsubscribe scheduled actions after execution', () => {
  let subscribeSpy: any = null;
  const counts: number[] = [];
 
  const e1 = cold('a|');
- const expected = '--a-(a|)';
+ const expected =  '--a-(a|)';
  const duration = time('-|');
  const result = e1.pipe(
  repeatWhen(notifications => {

diff --git a/src/internal/operators/delay.ts b/src/internal/operators/delay.ts
@@ -92,6 +92,7 @@ class DelaySubscriber<T> extends Subscriber<T> {
  const delay = Math.max(0, queue[0].time - scheduler.now());
  this.schedule(state, delay);
  } else {
+ this.unsubscribe();
  source.active = false;
  }
  }