Skip to content

Commit

Permalink
fix(distinctUntilKeyChanged): correct signatures
Browse files Browse the repository at this point in the history
  • Loading branch information
imcotton committed Aug 4, 2018
1 parent bb77e25 commit cd0dacd
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions compat/operator/distinctUntilKeyChanged.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { Observable } from 'rxjs';
import { distinctUntilKeyChanged as higherOrder } from 'rxjs/operators';

/* tslint:disable:max-line-length */
export function distinctUntilKeyChanged<T>(this: Observable<T>, key: string): Observable<T>;
export function distinctUntilKeyChanged<T, K>(this: Observable<T>, key: string, compare: (x: K, y: K) => boolean): Observable<T>;
export function distinctUntilKeyChanged<T>(this: Observable<T>, key: keyof T): Observable<T>;
export function distinctUntilKeyChanged<T>(this: Observable<T>, key: keyof T, compare: (x: T[keyof T], y: T[keyof T]) => boolean): Observable<T>;
/* tslint:enable:max-line-length */

/**
Expand Down Expand Up @@ -64,6 +64,6 @@ export function distinctUntilKeyChanged<T, K>(this: Observable<T>, key: string,
* @method distinctUntilKeyChanged
* @owner Observable
*/
export function distinctUntilKeyChanged<T>(this: Observable<T>, key: string, compare?: (x: T, y: T) => boolean): Observable<T> {
return higherOrder<T, T>(key, compare)(this);
export function distinctUntilKeyChanged<T>(this: Observable<T>, key: keyof T, compare?: (x: T[keyof T], y: T[keyof T]) => boolean): Observable<T> {
return higherOrder<T>(key, compare)(this);
}
6 changes: 3 additions & 3 deletions src/internal/operators/distinctUntilKeyChanged.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { distinctUntilChanged } from './distinctUntilChanged';
import { MonoTypeOperatorFunction } from '../types';

/* tslint:disable:max-line-length */
export function distinctUntilKeyChanged<T>(key: string): MonoTypeOperatorFunction<T>;
export function distinctUntilKeyChanged<T, K>(key: string, compare: (x: K, y: K) => boolean): MonoTypeOperatorFunction<T>;
export function distinctUntilKeyChanged<T>(key: keyof T): MonoTypeOperatorFunction<T>;
export function distinctUntilKeyChanged<T>(key: keyof T, compare: (x: T[keyof T], y: T[keyof T]) => boolean): MonoTypeOperatorFunction<T>;
/* tslint:enable:max-line-length */

/**
Expand Down Expand Up @@ -70,6 +70,6 @@ export function distinctUntilKeyChanged<T, K>(key: string, compare: (x: K, y: K)
* @method distinctUntilKeyChanged
* @owner Observable
*/
export function distinctUntilKeyChanged<T>(key: string, compare?: (x: T, y: T) => boolean): MonoTypeOperatorFunction<T> {
export function distinctUntilKeyChanged<T>(key: keyof T, compare?: (x: T[keyof T], y: T[keyof T]) => boolean): MonoTypeOperatorFunction<T> {
return distinctUntilChanged((x: T, y: T) => compare ? compare(x[key], y[key]) : x[key] === y[key]);
}

0 comments on commit cd0dacd

Please sign in to comment.