Skip to content

Commit

Permalink
refactor(types): remove internal APIs from Subscription and Observable
Browse files Browse the repository at this point in the history
  • Loading branch information
jasonaden committed Feb 22, 2018
1 parent 97c2284 commit f359f51
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/internal/Observable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@ import { pipeFromArray } from './util/pipe';
*/
export class Observable<T> implements Subscribable<T> {

/** @internal */
public _isScalar: boolean = false;

/** @internal */
protected source: Observable<any>;
/** @internal */
protected operator: Operator<any, T>;

/**
Expand Down Expand Up @@ -240,6 +243,7 @@ export class Observable<T> implements Subscribable<T> {
});
}

/** @internal */
protected _subscribe(subscriber: Subscriber<any>): TeardownLogic {
return this.source.subscribe(subscriber);
}
Expand Down
3 changes: 3 additions & 0 deletions src/internal/Subscription.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ export class Subscription implements SubscriptionLike {
*/
public closed: boolean = false;

/** @internal */
protected _parent: Subscription = null;
/** @internal */
protected _parents: Subscription[] = null;
/** @internal */
private _subscriptions: SubscriptionLike[] = null;
Expand Down Expand Up @@ -192,6 +194,7 @@ export class Subscription implements SubscriptionLike {
}
}

/** @internal */
private _addParent(parent: Subscription) {
let { _parent, _parents } = this;
if (!_parent || _parent === parent) {
Expand Down
1 change: 1 addition & 0 deletions src/internal/observable/ConnectableObservable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export class ConnectableObservable<T> extends Observable<T> {
protected _subject: Subject<T>;
protected _refCount: number = 0;
protected _connection: Subscription;
/** @internal */
_isComplete = false;

constructor(protected source: Observable<T>,
Expand Down

0 comments on commit f359f51

Please sign in to comment.