-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance tests interpretation #1228
Comments
According to the linked issue, there was a change in the selenium webdriver API that required a bunch of code in Angular 2 to be changed. This probably affected benchpress as well, which means it needs to be updated in order to support protractor 2.5.1, which this package depends on. |
…vDep. See angular/angular#2592 The selenium webdriver API changed between protractor 2.3 and 2.4. This affects benchpress, and has since been fixed in the angular repo. Update version of benchpress in package.json Fixes ReactiveX#1228
angular/angular#2592 The selenium webdriver API changed between protractor 2.3 and 2.4. This affects benchpress, and has since been fixed in the angular repo. Update version of benchpress in package.json Fixes ReactiveX#1228
…ular/protractor#2592 The selenium webdriver API changed between protractor 2.3 and 2.4. This change affects benchpress among other areas in angular2 codebase. Update benchpress dep version for compatibility with protractor 2.4+ Fixes ReactiveX#1228
I remember similar number was seen and benchpress update resolves those. Not sure if it's exactly same issue by #1230 updates it but number doesn't changes. |
The selenium webdriver API changed between protractor 2.3 and 2.4. This change affects benchpress among other areas in angular2 codebase (see angular/protractor#2596). Update benchpress dep version for compatibility with protractor 2.4+ Relates to ReactiveX#1228
The selenium webdriver API changed between protractor 2.3 and 2.4. This change affects benchpress among other areas in angular2 codebase (see angular/protractor#2592). Update benchpress dep version for compatibility with protractor 2.4+ Relates to ReactiveX#1228
The selenium webdriver API changed between protractor 2.3 and 2.4. This change affects benchpress among other areas in angular2 codebase (see angular/protractor#2596). Update benchpress dep version for compatibility with protractor 2.4+ Relates to #1228
cc @jeffbcross @tbosch looks like we're facing benchpress issues again. |
Is anyone else seeing the same thing when running perf tests? |
@jeffbcross I think benchpress is broken again. |
Closing this as stale. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I'm trying to run the perf tests on the following setup:
Here's the output for a sample test:
I'm trying to understand what this means. For example, the
scriptTime
, which is supposed to be the total of thepure
,gc
andrender
times (if I'm understanding correctly), is always 0, even in cases where the sum of those three values isn't zero.Also, the
pureScriptTime
is zero in all tests, which I'm assuming means the test is completing in negligible time, or that something is wrong. Is there a problem with my setup?The text was updated successfully, but these errors were encountered: