Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tests interpretation #1228

Closed
masaeedu opened this issue Jan 20, 2016 · 7 comments
Closed

Performance tests interpretation #1228

masaeedu opened this issue Jan 20, 2016 · 7 comments

Comments

@masaeedu
Copy link
Contributor

I'm trying to run the perf tests on the following setup:

  • Windows 10
  • Protractor 2.3.0 installed globally (Protractor 2.4.0+ causes this error)
  • chromedriver_2.19
  • selenium-server-standalone-2.47.1

Here's the output for a sample test:

BENCHMARK bufferCount Rx2
Description:
- forceGc: false
- iterations: 1000
- regressionSlopeMetric: scriptTime
- sampleSize: 20
- userAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.111 Safari/537.36
Metrics:
- gcAmount: gc amount in kbytes
- gcTime: gc time in ms
- majorGcTime: time of major gcs in ms
- pureScriptTime: script execution time in ms, without gc nor render
- renderTime: render time in ms
- scriptTime: script execution time in ms, including gc and render

          gcAmount |             gcTime |        majorGcTime |     pureScriptTime |         renderTime |         scriptTime
------------------ | ------------------ | ------------------ | ------------------ | ------------------ | ------------------
              0.00 |               0.00 |               0.00 |               0.00 |               0.22 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.09 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.06 |               0.00
            201.75 |               0.75 |               0.00 |               0.00 |               0.16 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.10 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.14 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.06 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.18 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.14 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.20 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.05 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.05 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.17 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.06 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.24 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.05 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.12 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.14 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.09 |               0.00
            643.57 |               1.77 |               0.00 |               0.00 |               0.08 |               0.00
================== | ================== | ================== | ================== | ================== | ==================
       42.27+-342% |         0.13+-325% |         0.00+-299% |               0.00 |          0.12+-48% |               0.00

I'm trying to understand what this means. For example, the scriptTime, which is supposed to be the total of the pure, gc and render times (if I'm understanding correctly), is always 0, even in cases where the sum of those three values isn't zero.

Also, the pureScriptTime is zero in all tests, which I'm assuming means the test is completing in negligible time, or that something is wrong. Is there a problem with my setup?

@masaeedu
Copy link
Contributor Author

According to the linked issue, there was a change in the selenium webdriver API that required a bunch of code in Angular 2 to be changed. This probably affected benchpress as well, which means it needs to be updated in order to support protractor 2.5.1, which this package depends on.

masaeedu added a commit to masaeedu/RxJS that referenced this issue Jan 20, 2016
…vDep. See angular/angular#2592

The selenium webdriver API changed between protractor 2.3 and 2.4. This affects benchpress, and has since been fixed in the angular repo. Update version of benchpress in package.json

Fixes ReactiveX#1228
masaeedu added a commit to masaeedu/RxJS that referenced this issue Jan 20, 2016
angular/angular#2592

The selenium webdriver API changed between protractor 2.3 and 2.4. This affects benchpress, and has since been fixed in the angular repo. Update version of benchpress in package.json

Fixes ReactiveX#1228
masaeedu added a commit to masaeedu/RxJS that referenced this issue Jan 20, 2016
…ular/protractor#2592

The selenium webdriver API changed between protractor 2.3 and 2.4. This change affects benchpress among other areas in angular2 codebase. Update benchpress dep version for
compatibility with protractor 2.4+

Fixes ReactiveX#1228
@kwonoj
Copy link
Member

kwonoj commented Jan 20, 2016

I remember similar number was seen and benchpress update resolves those. Not sure if it's exactly same issue by #1230 updates it but number doesn't changes.

masaeedu added a commit to masaeedu/RxJS that referenced this issue Jan 20, 2016
The selenium webdriver API changed between protractor 2.3 and 2.4. This change affects benchpress among other areas in angular2 codebase (see angular/protractor#2596). Update benchpress dep version for compatibility with protractor 2.4+

Relates to ReactiveX#1228
masaeedu added a commit to masaeedu/RxJS that referenced this issue Jan 20, 2016
The selenium webdriver API changed between protractor 2.3 and 2.4. This change affects benchpress among other areas in angular2 codebase (see angular/protractor#2592). Update benchpress dep version for
compatibility with protractor 2.4+

Relates to ReactiveX#1228
kwonoj pushed a commit that referenced this issue Jan 20, 2016
The selenium webdriver API changed between protractor 2.3 and 2.4. This change affects benchpress among other areas in angular2 codebase (see angular/protractor#2596). Update benchpress dep version for compatibility with protractor 2.4+

Relates to #1228
@masaeedu masaeedu mentioned this issue Jan 22, 2016
@benlesh
Copy link
Member

benlesh commented Jan 22, 2016

cc @jeffbcross @tbosch looks like we're facing benchpress issues again.

@masaeedu
Copy link
Contributor Author

masaeedu commented Feb 7, 2016

Is anyone else seeing the same thing when running perf tests?

@benlesh
Copy link
Member

benlesh commented Feb 7, 2016

@jeffbcross I think benchpress is broken again.

@benlesh
Copy link
Member

benlesh commented Jun 17, 2016

Closing this as stale.

@benlesh benlesh closed this as completed Jun 17, 2016
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants