-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not find a declaration file for module '@reactivex/rxjs' (5.5.x) #3005
Comments
/cc @jasonaden as well for visibility. |
@kwonoj I don't know if we need two separate PRs for this as they are the same fix. But I sent both just to make sure we don't miss the merge on either |
@jasonaden I think for these kind PR we may need who merges pr manually cherrypick into master to avoid ppl have to create same pr twice, but for now for opened PR I also think it should be fine. |
@kwonoj Agreed. On the Angular project we adopted certain labels so the person merging knows what to do. And we recently wrote scripts that will do rebasing based on the labels. Might want to adopt something similar. It's basically covered in this doc and has drastically simplified the process of merging PRs to the correct branches. |
Thanks for taking care of this @kwonoj and @jasonaden! Do you know when we'll get a new release from stable? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
RxJS version:
5.5.0, 5.5.1, 5.5.2
Code to reproduce:
index.ts
package.json
Expected behavior:
No errors.
Actual behavior:
Additional information:
The
package.json
of rxjs contains"typings": "./dist/package/typings/Rx.d.ts"
, but there is notypings
folder in thepackage
directory. I expect that it should be changed to"typings": "./dist/typings/Rx.d.ts"
, because that appears to work.The text was updated successfully, but these errors were encountered: