AjaxObservable: Redirections (including Not Modified) are wrapped in AjaxError.

[SleeplessByte]

RxJS version:
5.5.6 / stable

Code to reproduce:

const request: AjaxRequest = { 
  ...requestThatWillReturnAStatusCodeAbove299Below400
}

Observable
  .ajax(request)
  .subscribe(console.log, console.error)

Expected behavior:
I get the AjaxResponse in the console.log, just like any 2XX response.

Actual behavior:

Additional information:

rxjs/src/internal/observable/dom/AjaxObservable.ts

Line 368 in 94156a2

if (200 <= status && status < 300) {

Over here for some reason it defines only status between 200 and 300 (Exclusive) to be "next" worthy. The rest is all piped to an AjaxError. Status codes starting at 400 should error, but the (1XX,) 2XX and 3XX should all be valid responses.

Redirects are (rightly so) not handled, but it should not be an error. Since you get the raw AjaxResponse anyway, you'll need handling regardless; but why make a "regular case" (think 304 Not Modified, or a 302 Found) a wrapped result into AjaxError.

https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html 4XX and 5XX are errors.

[claudiordgz]

I'm grabbing this! ✋

[benlesh]

@SleeplessByte thanks for reporting this. It looks like @claudiordgz would like to implement the fix.

[claudiordgz]

Yes I would!

[claudiordgz]

PR #3438 created, feedback super welcomed 🙏

[SleeplessByte]

This was merged (#3438) 2128932