Observable does not complete using Sync/Async between two instances of RxJS

[hansl]

Smallest reproduction: https://stackblitz.com/edit/rxjs-3475-reproduction?file=index.ts

This is an issue we found in the Angular DevKit when updating projects and RxJS does not get properly hoisted (either because different versions or no peer deps).

Basically:

1. create an observable using Library 1
2. pipe a sync operator from Library 2
3. pipe an async operator from Library 1 (or 2)
4. the original SafeSubscriber is stopped, but did not complete or error, therefore the new pipeline will never next or complete the first pipeline.

[kwonoj]

Dupe of #3443. Rx doesn't support multiple instance due to internal core behavior.

[hansl]

@kwonoj Talking to @benlesh, it seems like this behaviour is officially supported.

You only use instanceof when whether or not you need a SafeSubscriber. All other instances you use the symbol-observable, which is the right behaviour. The problem is in SafeSubscriber, which Ben is looking at.

[kwonoj]

@benlesh mind chime in to share discussion in issue? I doubt even without instanceof check it'll work across different version / instances.

[kwonoj]

I'm leaving this closed for now and @benlesh can reopen per cases.

[benlesh]

This is a legit nasty bug. Working on the fix.

[benlesh]

This was fixed by #3477

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.