-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dtslint for better type expectations #3823
Comments
benlesh
added
type: discussion
AGENDA ITEM
Flagged for discussion at core team meetings
labels
Jun 11, 2018
Closed
cartant
added a commit
to cartant/rxjs
that referenced
this issue
Jul 23, 2018
Replace the rest parameters overload with a signature that also includes the A-I type parameters. Closes ReactiveX#3823 ReactiveX#3841
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Feature Request
To better test TypeScript expectations, we should be able to utilise Microsoft's dtslint tool.
I've had a look at how it could be integrated into the repo and I've created a branch that adds a
dtslint
script and adds thedtslint
-related configuration and type-only tests to thetype-specs
directory:cartant/rxjs/tree/dtslint/type-specs
The
dtslint
script can be added to the Travis$FULL_VALIDATE
configuration.This looks to me to be a great tool. Thoughts?
I was thinking that the
type
tests currently used in the test suite could be pretty easily be brought across todtslint
- in which the expectations would be more robustly tested.Additional context
The text was updated successfully, but these errors were encountered: