Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

count(predicate) plus tests #425

Closed
staltz opened this issue Sep 30, 2015 · 3 comments
Closed

count(predicate) plus tests #425

staltz opened this issue Sep 30, 2015 · 3 comments
Labels
help wanted Issues we wouldn't mind assistance with.

Comments

@staltz
Copy link
Member

staltz commented Sep 30, 2015

count() is currently missing the predicate function as argument.

Should we do this or not?
@benlesh benlesh added the help wanted Issues we wouldn't mind assistance with. label Sep 30, 2015
@benlesh
Copy link
Member

benlesh commented Sep 30, 2015

Yes, that should be a thing.

staltz pushed a commit to staltz/RxJSNext that referenced this issue Oct 1, 2015
feat(count): add predicate support in count()
06fe752 
Add a predicate function argument (and a thisArg argument) to count()
operator. Also add respective tests that mirror RxJS 4 tests.

Resolves issue ReactiveX#425.
@staltz staltz mentioned this issue Oct 1, 2015
Closed
@staltz
Copy link
Member Author

staltz commented Oct 2, 2015

This is closed by #436 @Blesh

@staltz
Copy link
Member Author

staltz commented Oct 2, 2015

Actually I have closing powers, so here we go.

@staltz staltz closed this as completed Oct 2, 2015
benlesh pushed a commit that referenced this issue Oct 3, 2015
@benlesh
feat(count): add predicate support in count()
42d1add 
Add a predicate function argument (and a thisArg argument) to count()
operator. Also add respective tests that mirror RxJS 4 tests.

Resolves issue #425.
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@staltz @benlesh