-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forkJoin(Promise) "You provided 'null' where a stream was expected" #4737
Labels
bug
Confirmed bug
Comments
cartant
added a commit
to cartant/rxjs
that referenced
this issue
Apr 26, 2019
cartant
added a commit
to cartant/rxjs
that referenced
this issue
Apr 26, 2019
BioPhoton
pushed a commit
to BioPhoton/rxjs
that referenced
this issue
May 15, 2019
* test(forkJoin): add failing test for ReactiveX#4737 * fix(forkJoin): test for object literal not observable Closes ReactiveX#4737.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
Current Behavior
After #4640,
forkJoin(promise)
throws an errorNote that this only happens if you provide
forkJoin
with a single argument of typePromise
.Reproduction
Expected behavior
forkJoin(promise)
should behave the same asforkJoin([promise])
, like it does for Observable.Environment
Possible Solution
Don't just check for
isObservable
, but alsoisPromise
(and strictly speaking, check for Iterable too).rxjs/src/internal/observable/forkJoin.ts
Line 150 in cd5895d
should become
The text was updated successfully, but these errors were encountered: