Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscription doesn't remove itself from parent subscriptions' _teardowns as expected when unsubscribed #6351

Closed
panchaow opened this issue May 4, 2021 · 0 comments
Labels
7.x Issues and PRs for version 7.x bug Confirmed bug

Comments

@panchaow
Copy link

panchaow commented May 4, 2021

Bug Report

excuse any English errors

in subscription.unsubscribe, mutating _parentage while for-looping it results in some items being skipped. relative lines are:

for (const parent of _parentage) {
   parent.remove(this); // will call `_removeParent` on `this`
}

Reproduction
codesandbox

cartant added a commit to cartant/rxjs that referenced this issue May 4, 2021
cartant added a commit to cartant/rxjs that referenced this issue May 4, 2021
@cartant cartant added 7.x Issues and PRs for version 7.x bug Confirmed bug labels May 4, 2021
@benlesh benlesh closed this as completed in 88331d2 May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.x Issues and PRs for version 7.x bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants