Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation for delayWhen should not say that it triggers for notifiers that complete without emitting #6977

Closed
roger6106 opened this issue May 24, 2022 · 0 comments · Fixed by #7028
Assignees

Comments

@roger6106
Copy link

Describe the bug

When the change in #3665 was implemented, the documentation was not updated. The documentation still states:

The source value is emitted on the output Observable only when the duration Observable emits a value or completes. The completion of the notifier triggering the emission of the source value is deprecated behavior and will be removed in future versions.

Expected behavior

As that behaviour has been removed, the text should be updated to remove the text that's complete (or alternatively, clarify that previous versions behaved differently):

The source value is emitted on the output Observable only when the duration Observable emits a value or completes. The completion of the notifier triggering the emission of the source value is deprecated behavior and will be removed in future versions.

Reproduction code

No response

Reproduction URL

No response

Version

7

Environment

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants