Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rxjs@8.0.0-alpha.13 has peer deps?! Oops #7426

Closed
benlesh opened this issue Jan 11, 2024 · 0 comments · Fixed by #7427
Closed

rxjs@8.0.0-alpha.13 has peer deps?! Oops #7426

benlesh opened this issue Jan 11, 2024 · 0 comments · Fixed by #7427

Comments

@benlesh
Copy link
Member

benlesh commented Jan 11, 2024

Apparently, when I migrated to a monorepo, something automated added peer deps of typescript and @types/node... that's completely silly. Those are dev dependencies. There's no reason anyone consuming rxjs needs those.

🤦
benlesh added a commit to benlesh/rxjs that referenced this issue Jan 11, 2024
@benlesh
fix(rxjs): removed unnecessary peer deps
8cf2663 
resolves ReactiveX#7426
@benlesh benlesh mentioned this issue Jan 11, 2024
Merged
benlesh added a commit that referenced this issue Jan 11, 2024
@benlesh
fix(rxjs): removed unnecessary peer deps (#7427)
5b6f6ea 
* fix(rxjs): removed unnecessary peer deps

resolves #7426

* chore(rxjs.dev): fix types and unbreak build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rxjs): removed unnecessary peer deps benlesh/rxjs
1 participant
@benlesh